Skip to content

Stabilize MImage/MVideoBodyView snapshots#33289

Merged
Half-Shot merged 4 commits intodevelopfrom
hs/fix-shared-component-sample-imports
Apr 24, 2026
Merged

Stabilize MImage/MVideoBodyView snapshots#33289
Half-Shot merged 4 commits intodevelopfrom
hs/fix-shared-component-sample-imports

Conversation

@Half-Shot
Copy link
Copy Markdown
Member

Importing a file via URL was causing the snapshots to end up with flaky hostnames on my system, unsure why but I suppose there is something special about my setup. Netherthless, we can do better here and use a more stable snapshot by using import that only includes the path to the file.

Checklist

Comment thread packages/shared-components/src/@types/global.d.ts Outdated
@Half-Shot Half-Shot marked this pull request as ready for review April 24, 2026 08:06
@Half-Shot Half-Shot requested a review from a team as a code owner April 24, 2026 08:06
@Half-Shot Half-Shot requested review from dbkr and t3chguy April 24, 2026 08:06
@Half-Shot Half-Shot added this pull request to the merge queue Apr 24, 2026
Merged via the queue into develop with commit 6c7c90c Apr 24, 2026
50 checks passed
@Half-Shot Half-Shot deleted the hs/fix-shared-component-sample-imports branch April 24, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants